comparisonSignals of PowerConverters #4353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Examples.DCDC.HBridge.*
AHaumer
added
enhancement
10 tasks
beutlich
added
L: Resources
hubertus65
approved these changes
Mar 27, 2024
Harisankar-Allimangalath
pushed a commit
to Harisankar-Allimangalath/ModelicaStandardLibrary_1
that referenced
this pull request
Mar 28, 2024
…eResults comparisonSignals of PowerConverters
|
FYI @AHaumer @christiankral @hubertus65 I have created a PR to backport this #4372 . Thankyou |
Harisankar-Allimangalath
pushed a commit
to Harisankar-Allimangalath/ModelicaStandardLibrary_1
that referenced
this pull request
Mar 28, 2024
…eResults comparisonSignals of PowerConverters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve comparisonSignals.txt of Modelica.Electrical.PowerConverters.Examples.DCDC.HBridge.*
It doesn't make sense to compare potential and current of positive and negative pin on both sides, better compare voltage and current on both sides. This ensures better regression testing in the future.
@arunkumar-narasimhan this should be back-ported to 4.1.x and 4.0.x - thanks!