Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting off UsersGuides/ReleaseNotes #4355

Merged
merged 1 commit into from Apr 9, 2024

Conversation

HansOlsson
Copy link
Contributor

To make it easier to track changes.
As discussed at the MAP-Lib meeting.
Also to be cherry picked to maint/4.1.0

@HansOlsson HansOlsson added the documentation Issue addresses the documentation label Mar 12, 2024
@HansOlsson HansOlsson added this to the MSL4.1.0 milestone Mar 12, 2024
Copy link
Member

@beutlich beutlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The disadvantage of such a file modularization is that we lose track of the git history. But given that we rather add new classes to the ReleaseNotes.mo it might be accpetable.

@Harisankar-Allimangalath
Copy link
Contributor

@casella @HansOlsson @beutlich so does the present structure looks good and can we proceed with an approval ?

Thankyou

Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was automatically generated by Dymola, so I trust the content should be ok

@GallLeo GallLeo self-requested a review April 9, 2024 13:21
Copy link
Contributor

@GallLeo GallLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine, as discussed in MAP-LIB meeting.

@casella casella merged commit a877f52 into modelica:master Apr 9, 2024
6 checks passed
@beutlich beutlich modified the milestones: MSL4.1.0, MSL4.2.0 Apr 9, 2024
@Harisankar-Allimangalath
Copy link
Contributor

@HansOlsson @GallLeo @casella , we have to backport this to maint/4.1.x right , just a doubt as the milestone is changed . ?

Thanks

@beutlich
Copy link
Member

Also to be cherry picked to maint/4.1.0

I doubt it is necessary.

as the milestone is changed

  • If merged to master the milestone must not be MSL4.1.0.
  • I merged to master and also cherry-picked to maint/4.1.x, the milestone must not be set at all (since it should only occure in the release notes of the release where it occurred first).

@Harisankar-Allimangalath
Copy link
Contributor

Harisankar-Allimangalath commented Apr 17, 2024

@beutlich @casella @HansOlsson @GallLeo just clarifying my doubt and understanding the scenario , this change is not yet cherrypicked to the maint/4.1.x and we already have a branch which is contains the release note edits and is having the old structure . so we have to cherypick this change to that branch also . (or merge the maint/4.1.x to the releasenotes branch after backporting , which ever is better ) , and something of the above two has to be done right ?

beutlich added a commit that referenced this pull request May 7, 2024
beutlich added a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Issue addresses the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants