Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong usage of quantities in Modelica.Electrical.Analog.Interfaces.IdealSemiconductor #4387

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix wrong usage of quantities in Modelica.Electrical.Analog.Interfaces.IdealSemiconductor #4387

wants to merge 2 commits into from

Conversation

AHaumer
Copy link
Contributor

@AHaumer AHaumer commented Apr 16, 2024

fixes bug #4386

@AHaumer AHaumer added bug Critical/severe issue L: Electrical.Analog Issue addresses Modelica.Electrical.Analog labels Apr 16, 2024
@AHaumer AHaumer added this to the maintenance milestone Apr 16, 2024
@CLAassistant
Copy link

CLAassistant commented Apr 16, 2024 •
edited

CLA assistant check
All committers have signed the CLA.

@AHaumer
Copy link
Contributor Author

AHaumer commented Apr 16, 2024

WTF ... I've signed the CLA long time ago. What's going wrong here?

@AHaumer
same issue with Electrical.Analog.Ideal.{IdealTwoWaySwitch, IdealInte…
99c46d9 
…rmediateSwitch, ControlledIdealTwoWaySwitch, ControlledIdealIntermediateSwitch}
@beutlich
Copy link
Member

beutlich commented Apr 16, 2024 •
edited

What's going wrong here?

Your two commits have different commit authors.

  1. @AHaumer signed the CLA on 2020-01-14T09:15:43.761Z (via CLA Assistant)
  2. @haa39214 did not sign the CLA

If you do not want to update the commits it still can be fixed when squashing later.

@beutlich beutlich changed the title Wrong usage of quantities in Modelica.Electrical.Analog.Interfaces.IdealSemiconductor Fix wrong usage of quantities in Modelica.Electrical.Analog.Interfaces.IdealSemiconductor Apr 16, 2024
@AHaumer
Copy link
Contributor Author

AHaumer commented Apr 17, 2024 •
edited

I've used the same github user, just another notebook. No idea why the username is different and how I can sign the CLA with the other username because the two usernames are connected.
Well, in the end it seems that I've managed to sign the CLA with my second username.

HansOlsson
HansOlsson approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok, but more stylistic improvement than bug-fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HansOlsson HansOlsson HansOlsson approved these changes

@dietmarw dietmarw Awaiting requested review from dietmarw

@christiankral christiankral Awaiting requested review from christiankral

@casella casella Awaiting requested review from casella

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
bug Critical/severe issue L: Electrical.Analog Issue addresses Modelica.Electrical.Analog
Projects
None yet
Milestone
maintenance
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AHaumer @CLAassistant @beutlich @HansOlsson @haa39214