Skip to content
This repository has been archived by the owner on Oct 5, 2020. It is now read-only.

Prepare library for inclusion into MSL 4.0.0 #42

Closed
bernhard-thiele opened this issue Apr 3, 2019 · 2 comments
Closed

Prepare library for inclusion into MSL 4.0.0 #42

bernhard-thiele opened this issue Apr 3, 2019 · 2 comments
Assignees

Comments

@bernhard-thiele
Copy link
Collaborator

The Modelica_Synchronous library shall be included in the future MSL 4.0.0 (see modelica/ModelicaStandardLibrary#2862).

The questions is how to do this transition in a good way. I already experimented with simply using the Dymola rename function for moving the library into the package Modelica.ClockedBlocks. This worked without problems. Remaining manual work is updating the documentation and maybe conversion scripts (though I'm not sure if there is a need to automatically convert Modelica_Synchronous blocks to corresponding MSL 4.0.0 blocks).

However, it probably makes sense to first fix issues in the Modelica_Synchronous library before moving the code base into the MSL project. This could be done in an own branch, or in the master branch. An own branch has the advantage that quick experimental changes can be made without affecting or confusing users who rely on the master branch.

That's why I propose to add a new branch (e.g., msl4_0_0) for fixing the issues and preparing the library so that it can be easily transferred into the MSL 4.0.0.

@bernhard-thiele bernhard-thiele self-assigned this Apr 3, 2019
bernhard-thiele added a commit that referenced this issue Apr 3, 2019
@christoff-buerger
Copy link
Member

Fixing issues first sounds good. I have quiet a couple of things in mind that need some cleanup. But I need to find a free week to do some concentrated work (mostly related to the event clock examples).

What is our roughly time-schedule? Which deadlines do you like to set for the fixing-branch?

@bernhard-thiele
Copy link
Collaborator Author

I was roughly thinking about the next two months. There are not many open issues (at least not on the issue tracker).

bernhard-thiele added a commit that referenced this issue Apr 4, 2019
Some adaptions to top level documentation related to #42 and #35.
bernhard-thiele added a commit that referenced this issue Apr 9, 2019
For future integration into MSL (#42) this commit proposes text changes at the top level package to:
1. Adapt license to BSD-3 clause (closes #35).
2. Set MA as copyright holder.
bernhard-thiele added a commit that referenced this issue May 22, 2019
This concludes the preparation work before moving the library
to the MSL 4.0.0 development master.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants