Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed duplicate currentGear variable #22

Merged
merged 1 commit into from
Jun 7, 2018
Merged

Removed duplicate currentGear variable #22

merged 1 commit into from
Jun 7, 2018

Conversation

harmanpa
Copy link
Member

@harmanpa harmanpa commented Jun 7, 2018

As discussed in #17 & #19 this removes the duplicate declaration of currentGear so it is only declared once.

@harmanpa harmanpa merged commit 1b5ed4c into modelica:master Jun 7, 2018
@harmanpa harmanpa mentioned this pull request Jun 7, 2018
Closed
@tobolar
Copy link
Contributor

tobolar commented Jun 7, 2018

Well I don't believe Transmissions.Interfaces.StandardControlBus is the right place to delete currentGear. Actually, in the package VehicleInterfaces.Interfaces non of included buses contain any signal, and so should be with VehicleInterfaces.Interfaces.TransmissionControlBus.
All signals are defined in particular packages of assemblies only, i.e. VehicleInterfaces.Chassis.Interfaces, VehicleInterfaces.Engines.Interfaces, etc.

The reason to temporarily leave currentGear in VehicleInterfaces.Interfaces.TransmissionControlBus is only the backward compatibility, and it should be resolved in the next major version as indicated in #19.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@harmanpa @tobolar