Mark FMUs that are not compliant due to external dependencies #124
Conversation
There was a problem hiding this comment.
The FMI Steering Committee decided to back-port modelica/fmi-standard#1478 to FMI 2.0.3, which would make this PR obsolete. We can leave it open until the change has been merged.
Strictly speaking the FMUs with external dependencies will only be "legal" when the file externalDependencies.{txt|html} is present in the documentation folder. Shall we ask the tool vendors to "retrofit" their submitted FMUs with the this file including a description of the dependencies? |
FMI 2.0 FMUs "should" have the file, so not need to change existing FMUs. |
|
Closing as modelica/fmi-standard#1488 has been merged. |
@t-sommer, @chrbertsch, @andreas-junghanns , I understand there are some technical reasons (that are not further specified, so I don't know what they are) to not make this file required in FMI 2.0, hence the "should" in the 2.0.3 spec. I am of course fine with that. I wonder if the pool of cross-check FMUs shouldn't avoid including instances that should include the file, but actually don't (pun intended). Isn't this pool meant to be the golden yardstick for all tools to confront with? |
|
The "golden yardstick" should be the Reference FMUs. The XC pool is for the cold, hard reality of our dirty world. And there it is quite ok to show shortcomings in some of the tools because documenting this is also important to users out there wondering about which versions of which tools produce what kind of compatibility issues. |
|
@andreas-junghanns, you still crave for oil and grease, don't you 😄 |
This pull request marks those tests as not compliant that have external dependencies, see #122.
I tested only the targets win64 and linux64. There are probably similar issues on some of the other targets.