Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce Whitespace #30

Closed
xogeny opened this issue Apr 4, 2018 · 2 comments
Closed

Reduce Whitespace #30

xogeny opened this issue Apr 4, 2018 · 2 comments

Comments

@xogeny
Copy link

xogeny commented Apr 4, 2018

The current CSS (IIRC) uses media queries to determine screen size and then picks a fixed width based on width ranges. Using fixed widths as the advantage that it only a few specific widths are possible and so layout can be verified for each of those potential values.

One downside of fixed width layout is that you can wind up with significant amounts of white space in the left and right margins. Using fixed margins can result in greater utilization of the screen space but will mean that the width can take on an effectively infinite number of possible values. So care must be taken that the responsive design elements are robust in the face of so many possible widths.

@andreas-junghanns, in light of these comments do you want to push for the user of fixed margins (less overall whitespace)? I'm not trying to scare you off here, I'm just stating what I see as the pros and cons so other can comment as well if they see any issues with my analysis.

@andreas-junghanns
Copy link
Contributor

I think we should wait until we run into problems with the two-column mode (read: run out of space). Once we get to that point, we can discuss margins again.

@t-sommer
Copy link
Collaborator

t-sommer commented Sep 8, 2018

@xogeny, is this still an issue with the new Bootstrap based layout?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants