-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarification of alias variables (and variability) #436
Comments
I would not say that its good practice, but the most simple solution would be to assume and define the highest variability in that case, i.e continuous>discrete>tunabel>fixed. |
Decision: move to 3.0 |
FMI Design meeting Regensburg: First paragraph on p51. of FMI 2.0 spec says that this would not be problem. |
@KarlWernersson : Could you have look at it and come up with a proposal? If necessary please create a new ticket for FMI 3.0 |
So section 3 talks about variablity, and section 1 talks about causality so i dont see the crash. Basicaly you can only have multiple aliases between local, output and calcualted parameters, A set of aliases can include maximum of one parameter or input. If you dont have any input/parameter in the alias group then you can only retrieve values. Then the variability must be governed by the highest variability in this set of aliases, as this would be the lest intrusive option. (since it is always allowed to call get on any variability) Start Values are coverd by section2. So new normative text.
|
Aded normative text for the issue, corected an eronous != sign
* #436 Aded normative text for the issue, corected an eronous != sign * fix #547 explicitly state no backslashes, reference to zip file format specification * #440 fix Clarified that input cannot be set before fmi2EnterInitializationMode * #431 fixed Clearified text, corected variability = input to causality = input * #415 Moved section up in text to make it ceared that it applies to both flat and structured * #413 fix Clarified that scararVariables can be oredered arbitrary except for array elements * #409 Clarified that pure discrete time fmu's must be able to run as a continous time fmu * #407 fix Removed setConinuousTimeStates form the allowed calls in event mode in the mathematical description * #405 fix If pure discrete time fmu has crossing function it need to enter continuous time mode to solve these * #401 fix Recomedns that all binares in binary folder is unpacked togheter wiht the dll * #396 fix Clarified that the number of continuous time stiates is uniqley defined by the number of derivatives * #395 fix Cleard out inconsitency that getEventIndicators can be called duering intializationMode * #394 fix setTime is only allowed in eventMode for pureDiscreteTimeFMu's * #380 fix aded example for simple case * #374 fix * #311 * Fixing small typo * Fixing typo * Fix typo * Replace hard internal reference by ADOC internal reference (with a link) * Fix #417: add license folder * fix #95 * Fix #387 * (Following one-sentence-per-line rule) * fix #338 * fix build error * corected comment by masoud * christian comment about clarification 2.0.1 * Aditional fix #395
Closing as included in PR #579 |
This rule is now verified in VDMCheck, given that this has appeared in the 2.0.1 standard, Quite a few FMUs in the cross-check repository have issues (unless I have misinterpreted the rules), for example:
Here, "fixed.phi0" is a fixed parameter, so all its aliases must be, and 637534234/Real aliases are both discrete and continuous, and so should all be continuous. |
Looks like 125 of 692 FMUs have some sort of aliasing issue here. The results have been updated on the VDMCheck release page. |
Correction: 175 FMUs have errors (the 125 is just for Real aliases, but there are other types). |
@t-sommer Are these FMUs also candidates for the "notCompliantWithLatestRules" treatment? |
Potentially, yes. Please open an issue on modelica/fmi-cross-check. |
I think we should revisit this issue for two reasons: Looking at the new text it says (as non-normative text - so I don't see that it should be checked at all): I believe this should be reconsidered and reformulated, because:
|
superseded by #807 |
Reported by christian.winther on 6 Jun 2018 15:53 UTC
Question about alias variables. Say that I have two ScalarVariables that have the same value reference and the same type and thus are alias variables. Is it then legal for the two variables to have different variability?
I've been looking through the specification (both 1.0 and 2.0) and cannot see anything that specifically says it is illegal and also the compliance checker does not currently report an error for it but to me it seems that it should be illegal.
Migrated-From: https://trac.fmi-standard.org/ticket/436
The text was updated successfully, but these errors were encountered: