Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add intro synchronous clocks #1143

Merged
merged 16 commits into from
Aug 31, 2020
Merged

Conversation

clagms
Copy link
Collaborator

@clagms clagms commented Aug 29, 2020

Adds the introductory text described in #1073

@clagms clagms mentioned this pull request Aug 29, 2020
Copy link
Contributor

@andreas-junghanns andreas-junghanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it - brief intro with problem description and example.
Can we build this example in the Reference FMUs as examples?

@andreas-junghanns
Copy link
Contributor

Do you think you want to enhance this further and keep it in draft state?
When you think you are done, please mark as "ready for review".

@andreas-junghanns andreas-junghanns linked an issue Aug 29, 2020 that may be closed by this pull request
@clagms
Copy link
Collaborator Author

clagms commented Aug 30, 2020

Can we build this example in the Reference FMUs as examples?

Good idea. This would also validate the explanation. I've created https://github.com/modelica/fmi-standard/issues/1150 to keep track of this.

@clagms clagms marked this pull request as ready for review August 30, 2020 08:53
@andreas-junghanns
Copy link
Contributor

@masoud-najafi , @TorstenBlochwitz : can either of you read through the PR? I would like at least one more person to share the blame ;)

Copy link
Collaborator

@masoud-najafi masoud-najafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In 2_2_common_schema.adoc I cannot understand the following phrase, is it related to SE or the TriggeredBy attribute?

If <> = <> and <> = <> the <> tick event can occur only in the model partition that is related to the referenced <>, i.e. the <<outputClock,output clock>> value (active/inactive) can only change in this model partition.

@andreas-junghanns
Copy link
Contributor

In 2_2_common_schema.adoc I cannot understand the following phrase, is it related to SE or the TriggeredBy attribute?

If <> = <> and <> = <> the <> tick event can occur only in the model partition that is related to the referenced <>, i.e. the <<outputClock,output clock>> value (active/inactive) can only change in this model partition.

This sentence is not part of this PR. Can you open another a new issue for this?
If this is the only problem you have with this PR, do you approve?

@andreas-junghanns andreas-junghanns merged commit f795c2e into master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduction to Synchronous Clocks and open questions
3 participants