Explain matching of terminals with structured naming convention arrays in 2.0.4 #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrbertsch
changed the title
t-sommer
requested changes
Sep 12, 2022
| @@ -208,3 +208,6 @@ _[New in FMI 2.0.4:]_ | |||
| ==== Terminals and Icons | |||
|
|
|||
| The optional directory `terminalsAndIcons` contains the definition of the Ports and Icons of the FMU as defined in the FMI 3.0 Specification, 2.4.9. Terminals and Icons. | |||
|
|
|||
There was a problem hiding this comment.
This clarification doesn't help much.
There was a problem hiding this comment.
As we will explain this in 3.0.1 and the Implementer's Guide: Do we need an additional explaination for FMI 2.0.4 at all or can we close this PR?
|
In fact this remark is useless, once the maintenance release of FMI 3 is done. We decided to update FMI 3. I think we don't need this PR (hoping that we are actually going to release 3.0.1). |
|
Closing, as there seems to agreement now to clarify this in FMI 3.0.1 (PR #1808) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it is proposed to explain the matching in more detail in FMI 3.0 (#1808) and the IG, this consist mainly of a reference to these two places to avoid redundancies.
Please comment or create an alternative PR if you have a better suggestion.