Clarify earlyReturn from fmi3DoStep #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a comment that this should not be used if the step terminated early due to an error to resolve #1844
andreas-junghanns
approved these changes
Dec 15, 2022
pmai
requested changes
Dec 15, 2022
Co-authored-by: Pierre R. Mai <pmai@pmsf.de>
chrbertsch
approved these changes
Jan 10, 2023
andreas-junghanns
approved these changes
Jan 10, 2023
pmai
approved these changes
Jan 17, 2023
t-sommer
pushed a commit
to t-sommer/fmi-standard
that referenced
this pull request
Jan 31, 2023
* Define default variability as discrete for variables other than Float according to Pierre's suggestion * Update based on Antoine's comment in modelica#1845
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a comment that this should not be used if the step terminated early due to an error to resolve #1844