Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify use of binaries and resources folder #1849

Merged
merged 5 commits into from Feb 5, 2023

Conversation

chrbertsch
Copy link
Collaborator

New apptempt to fix #1822 as discussed in todays design meeting. See #1832 (comment)

Copy link
Collaborator

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Stylistically I might prefer (en-)dashes rather than parens for the parenthetical expressions, but is just my typographic preference.

@chrbertsch chrbertsch merged commit abf1581 into modelica:main Feb 5, 2023
@@ -50,7 +50,8 @@ sources // directory containing the C sources (optio
binaries // directory containing the binaries (optional)
x86_64-windows // binaries for Windows on Intel 64-bit
<modelIdentifier>.dll // shared library of the FMI implementation
<other DLLs> // the DLL can include other DLLs
<other files> // other platform dependend files
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrbertsch is it clear enough that are allowed in parallel subfolders as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relax content description of /binaries folder
5 participants