Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify array concat #1882

Merged
merged 2 commits into from
Jun 5, 2023
Merged

Clarify array concat #1882

merged 2 commits into from
Jun 5, 2023

Conversation

chrbertsch
Copy link
Collaborator

Resolves #1877

Other API functions that use concatenated (serialized) array varaibles to be checked.

andreas-junghanns
andreas-junghanns approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@andreas-junghanns andreas-junghanns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the original text is clear because no sane alternative way of reading this makes sense.
But the new sentence makes it slightly clearer, albeit at the expense of extra, potentially unnecessary verbiage...

@chrbertsch chrbertsch marked this pull request as ready for review June 5, 2023 07:41
@chrbertsch chrbertsch merged commit 9e5532e into modelica:main Jun 5, 2023
3 checks passed
@pmai pmai mentioned this pull request Jun 6, 2023
Closed
@chrbertsch chrbertsch mentioned this pull request Jun 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreas-junghanns andreas-junghanns andreas-junghanns approved these changes

@klausschuch klausschuch Awaiting requested review from klausschuch

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clarification for concatenation of arrays in get/set functions
2 participants
@chrbertsch @andreas-junghanns