New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse objectid #20
Merged
Merged
Parse objectid #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Fix for the recursive toJSON calling in base modella which was converting `ObjectID`s into strings before the save method is called. Setting `{type: ObjectID}` on an attribute will cause any string value passed in to be parsed into an `ObjectID`.
paulbdavis
force-pushed
the
parse-objectid
branch
from
October 8, 2014 16:21
573ef86
to
4e7b827
Compare
Rebased with conflict fix, should be good to merge this now |
This looks good but would also like to see string support, ie |
Noted, will push that in a second |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for the recursive toJSON calling in base modella which was
converting
ObjectID
s into strings before the save method is called.Setting
{type: ObjectID}
on an attribute will cause any string valuepassed in to be parsed into an
ObjectID
.