Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse objectid #20

Merged
merged 4 commits into from Oct 8, 2014
Merged

Parse objectid #20

merged 4 commits into from Oct 8, 2014

Conversation

paulbdavis
Copy link
Contributor

Fix for the recursive toJSON calling in base modella which was
converting ObjectIDs into strings before the save method is called.

Setting {type: ObjectID} on an attribute will cause any string value
passed in to be parsed into an ObjectID.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 38affa4 on paulbdavis:parse-objectid into bfd1b77 on modella:master.

@paulbdavis paulbdavis mentioned this pull request Oct 8, 2014
Fix for the recursive toJSON calling in base modella which was
converting `ObjectID`s into strings before the save method is called.

Setting `{type: ObjectID}` on an attribute will cause any string value
passed in to be parsed into an `ObjectID`.
@paulbdavis
Copy link
Contributor Author

Rebased with conflict fix, should be good to merge this now

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 573ef86 on paulbdavis:parse-objectid into bfd1b77 on modella:master.

@rschmukler
Copy link
Member

This looks good but would also like to see string support, ie 'ObjectId' should also work.

@paulbdavis
Copy link
Contributor Author

Noted, will push that in a second

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 4e7b827 on paulbdavis:parse-objectid into 70f7d20 on modella:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1a4ed58 on paulbdavis:parse-objectid into 70f7d20 on modella:master.

rschmukler added a commit that referenced this pull request Oct 8, 2014
@rschmukler rschmukler merged commit da51734 into modella:master Oct 8, 2014
@paulbdavis paulbdavis deleted the parse-objectid branch October 8, 2014 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants