Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Participation in FMU Cross Check #5

Open
chrbertsch opened this issue May 19, 2020 · 4 comments
Open

Participation in FMU Cross Check #5

chrbertsch opened this issue May 19, 2020 · 4 comments

Comments

@chrbertsch
Copy link

It would be highly beneficial if FMI-Library would participate in the FMI Cross Check https://github.com/modelica/fmi-cross-check. For many tools this has significantly improved the maturity of their FMI support.

@filip-stenstrom
Copy link
Collaborator

FMIL doesn't provide any master algorithm for simulating arbitrary FMUs, so it's not an "importing tool" (it's just a library). However, if any importing tool that's using FMIL is passing XC, then the used version of FMIL should also "pass".

We could perhaps make references in the project README to importing tools that use FMIL, and that are listed in XC. This would not show up in the XC tables though. Any thoughts @iakovn ?

@chrbertsch
Copy link
Author

Hello Filip, you have examples like https://github.com/modelon-community/fmi-library/blob/master/Test/FMI2/fmi2_import_me_test.c where you simulate FMUs. Couldn't you adapt this for the XC FMUS and report the result??
Typically, in the FMI cross-Check , the more fundamental questions like errors in the XML are detected and not deep numerical problems that would require an advanced solver (for ME FMUs) or master (for CS FMUs; in the XC we deal with single FMUs anyway). The information, which FMUs can be treated with FMIL would be very valuable!

@iakovn
Copy link
Member

iakovn commented May 25, 2020

I agree with Filip that FMIL that unless we include at least a basic simulation + master algorithm + input/output handling into the library reporting XC results is a bit misleading. I think that we should rather indicate that pyfmi is relying on FMIL when reporting the results to XC in some way.
@chria - what do you think?

@chria
Copy link

chria commented May 25, 2020

@iakovn I think this is reasonable. I'm in favor of indicating that PyFMI relies on FMIL and that the XC results of PyFMI points also to the maturity of FMIL.

beutlich pushed a commit to fmi-tools/fmi-library that referenced this issue Apr 1, 2021
Extend API: check if DefaultExperiment attributes defined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants