Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added mapping for python client-MI version compatibility #207

Merged
merged 1 commit into from
May 28, 2023

Conversation

abhilash-kumar-nair
Copy link
Contributor

Copy link
Member

@iakovn iakovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be really helpful! Only comment is to use inexact version spec to avoid any confusion about patch versions.
Other thing I'm unsure about is if we need to separate desktop from cloud version

docs/source/install.rst Show resolved Hide resolved
@maraberg
Copy link

I like this very much. It would be appreciated if this was reflected here as well: https://modelon-impact-client.readthedocs.io/en/latest/install.html

@iakovn
Copy link
Member

iakovn commented May 25, 2023

I like this very much. It would be appreciated if this was reflected here as well: https://modelon-impact-client.readthedocs.io/en/latest/install.html

@maraberg This will be published when merged. Or do you mean adding a pointer to the new text from the first section?

@maraberg
Copy link

I like this very much. It would be appreciated if this was reflected here as well: https://modelon-impact-client.readthedocs.io/en/latest/install.html

@maraberg This will be published when merged. Or do you mean adding a pointer to the new text from the first section?

Good, yes I mean this information should be available in the installation page of the documentation.

@abhilash-kumar-nair
Copy link
Contributor Author

Hi @maraberg , @iakovn , Thanks for suggestion! I have now made the suggested fixes. Could you please take another look?

@maraberg
Copy link

Looks good!

Copy link
Member

@iakovn iakovn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants