Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds selective Element Model Attributes #231

Open
wants to merge 4 commits into
base: v8/dev
Choose a base branch
from

Conversation

pgregorynz
Copy link

Hey Stephan. I know that you were going to be doing something like this in MB but we needed selective models in Models and in Elements so updated our fork and thought we should send a pull request for consideration. :)

Ignores types that are of type PublishedElementModel when applying a custom base class attribute
Adds the ability to create a Element base class
@ronaldbarendse
Copy link

This adds quite a lot of complex code, seems to change existing functionality and doesn't have any tests... Could you start by adding a description of what this PR adds and why it should be included? That would make reviewing this a lot easier 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants