Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Distributed Modules #18

Merged
merged 15 commits into from
Feb 1, 2024
Merged

Refactor Distributed Modules #18

merged 15 commits into from
Feb 1, 2024

Conversation

pan-x-c
Copy link
Collaborator

@pan-x-c pan-x-c commented Jan 23, 2024 •
edited

name: Refactor Distributed Modules

Description

  1. refactor PlaceholderMessage, make the usage of PlaceholderMessage exactly the same as Msg, and hide the internal update method from users.
  2. refactor initialization method of RPC server subprocess, avoid duplicated initialization, and simplify the complexity of distributed initialization.
  3. remove RpcAgentBase, use to_dist to transform AgentBase instances into its distributed version.
  4. update docstring, tutorial, tests, and examples of distributed related modules

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@pan-x-c pan-x-c added the enhancement New feature or request label Jan 23, 2024
@pan-x-c pan-x-c self-assigned this Jan 23, 2024
@pan-x-c pan-x-c changed the title [WIP] Refactor Distributed Modules Refactor Distributed Modules Jan 25, 2024
DavdGao
DavdGao reviewed Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, please see inline comments for some minor modifications.

docs/sphinx_doc/source/tutorial/208-distribute.md Show resolved Hide resolved
docs/sphinx_doc/source/tutorial/208-distribute.md Show resolved Hide resolved
examples/distributed/distributed_debate.py Outdated Show resolved Hide resolved
src/agentscope/agents/agent.py Outdated Show resolved Hide resolved
DavdGao
DavdGao reviewed Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz see inline comments

docs/sphinx_doc/source/tutorial/208-distribute.md Show resolved Hide resolved
examples/distributed/distributed_debate.py Outdated Show resolved Hide resolved
DavdGao
DavdGao approved these changes Feb 1, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavdGao DavdGao merged commit 70f6d8c into modelscope:main Feb 1, 2024
3 checks passed
FredericW pushed a commit to FredericW/agentscope that referenced this pull request Jun 6, 2024
@ZiTao-Li
Merge pull request modelscope#18 from ZiTao-Li/zitao/dev_copilot
f9a1308 
update as comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavdGao DavdGao DavdGao approved these changes

@qbc2016 qbc2016 Awaiting requested review from qbc2016

Assignees

@pan-x-c pan-x-c

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pan-x-c @DavdGao