New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in service_factory #52

Merged

DavdGao merged 1 commit into modelscope:main from DavdGao:hotfix/agent_and_service_factory

Mar 10, 2024

Collaborator

DavdGao commented Mar 8, 2024 •

edited

Description

Move ServiceFactory into agentscope.service.ServiceFactory
Check if all arguments don't have default values.

Checklist

Please check the following items before code is ready to be reviewed.

Code has passed all tests
Docstrings have been added/updated in Google Style
Documentation has been updated
Code is ready for review


          fix bug in service_factory

DavdGao requested review from pan-x-c, rayrayraykk and qbc2016

March 8, 2024 04:15

rayrayraykk approved these changes

View reviewed changes

Collaborator

rayrayraykk left a comment

LGTM

DavdGao merged commit 6491eea into modelscope:main

4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment