Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add groupchat with @ example #55

Merged
merged 15 commits into from
Mar 14, 2024
Merged

Add groupchat with @ example #55

merged 15 commits into from
Mar 14, 2024

Conversation

rayrayraykk
Copy link
Collaborator

name: add groupchat with @

Description

@ someone in group chat

NOTE: timer might cause error in as_studio, which needs a hotfix.

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

DavdGao
DavdGao reviewed Mar 10, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please see inline comments
  2. Add a README.md for this example.
  3. In our example, it's suggested not to involve any real people.

src/agentscope/utils/common.py Outdated Show resolved Hide resolved
examples/groupchat/prompt.py Outdated Show resolved Hide resolved
DavdGao
DavdGao reviewed Mar 12, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plz see inline comments.

examples/groupchat/README.md Outdated Show resolved Hide resolved
examples/groupchat/main.py Show resolved Hide resolved
src/agentscope/utils/common.py Show resolved Hide resolved
@rayrayraykk rayrayraykk added the enhancement New feature or request label Mar 12, 2024
pan-x-c
pan-x-c reviewed Mar 12, 2024
View reviewed changes
examples/groupchat/main.py Outdated Show resolved Hide resolved
@rayrayraykk rayrayraykk changed the title add groupchat with @ Add groupchat with @ example Mar 13, 2024
@rayrayraykk rayrayraykk mentioned this pull request Mar 13, 2024
Closed
DavdGao
DavdGao approved these changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DavdGao
Copy link
Collaborator

DavdGao commented Mar 14, 2024

Please resolve the conflicts

@rayrayraykk
Copy link
Collaborator Author

Please resolve the conflicts

Resolved

@DavdGao DavdGao merged commit 1d4c6f9 into modelscope:main Mar 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qbc2016 qbc2016 qbc2016 left review comments

@pan-x-c pan-x-c pan-x-c left review comments

@DavdGao DavdGao DavdGao approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rayrayraykk @DavdGao @qbc2016 @pan-x-c