Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AS studio in README #90

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Add AS studio in README #90

merged 5 commits into from
Mar 26, 2024

Conversation

qbc2016
Copy link
Collaborator

@qbc2016 qbc2016 commented Mar 20, 2024 •
edited by DavdGao

Description

Add AS studio in README

Checklist

Please check the following items before code is ready to be reviewed.

  • Code has passed all tests
  • Docstrings have been added/updated in Google Style
  • Documentation has been updated
  • Code is ready for review

@rayrayraykk
Copy link
Collaborator

Please tell users to install [full] version to use as_studio, since the minimal version do not include gradio and ms_studio.

DavdGao
DavdGao reviewed Mar 22, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plz see inline comments.

README.md Show resolved Hide resolved
DavdGao
DavdGao approved these changes Mar 23, 2024
View reviewed changes
Copy link
Collaborator

@DavdGao DavdGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, plz ensure the modification in logger won't affect the running of examples.

@DavdGao DavdGao merged commit 3e33a27 into modelscope:main Mar 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayrayraykk rayrayraykk rayrayraykk left review comments

@DavdGao DavdGao DavdGao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@qbc2016 @rayrayraykk @DavdGao