Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/image text matching #100

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Feature/image text matching #100

merged 8 commits into from
Dec 6, 2023

Conversation

zhijianma
Copy link
Collaborator

  1. add image_text_matching_filter
  2. rename clip_similarity_filter to image_text_similarity_filter, and add flip option

@HYLcool HYLcool added enhancement New feature or request dj:multimodal issues/PRs about multimodal data processing labels Nov 28, 2023
@HYLcool HYLcool added this to the Multimodal Support milestone Nov 28, 2023
@HYLcool HYLcool mentioned this pull request Dec 5, 2023
Closed
3 tasks
@HYLcool HYLcool linked an issue Dec 5, 2023 that may be closed by this pull request
[Bug]: RAY error #107
Closed
3 tasks
HYLcool
HYLcool reviewed Dec 5, 2023
View reviewed changes
docs/Operators.md Outdated Show resolved Hide resolved
@zhijianma zhijianma linked an issue Dec 6, 2023 that may be closed by this pull request
[MM] add image_text_matching_filter OP #119
Closed
HYLcool
HYLcool approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@HYLcool HYLcool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhijianma zhijianma merged commit 2859ea1 into main Dec 6, 2023
5 checks passed
@zhijianma zhijianma deleted the feature/image_text_matching branch December 6, 2023 02:43
@HYLcool HYLcool added the dj:op issues/PRs about some specific OPs label Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HYLcool HYLcool HYLcool approved these changes

@drcege drcege Awaiting requested review from drcege

@chenhesen chenhesen Awaiting requested review from chenhesen

@BeachWang BeachWang Awaiting requested review from BeachWang

@yxdyc yxdyc Awaiting requested review from yxdyc

Assignees

@zhijianma zhijianma

Labels
dj:multimodal issues/PRs about multimodal data processing dj:op issues/PRs about some specific OPs enhancement New feature or request
Projects
None yet
Milestone
Basic Multimodal Support
Development

Successfully merging this pull request may close these issues.

[MM] add image_text_matching_filter OP [Bug]: RAY error
2 participants
@zhijianma @HYLcool