Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance/face area filter #202

Merged
merged 2 commits into from
Jan 30, 2024
Merged

Enhance/face area filter #202

merged 2 commits into from
Jan 30, 2024

Conversation

drcege
Copy link
Collaborator

@drcege drcege commented Jan 30, 2024 •
edited

  • Constrain the detection coordinates within the image so that the filtering ratios can be deterministically controlled between 0 and 1.
  • Add debug logging for future inspection when unit test inconsistencies arise.

@drcege drcege added enhancement New feature or request dj:op issues/PRs about some specific OPs labels Jan 30, 2024
@drcege drcege self-assigned this Jan 30, 2024
@drcege drcege added the dj:multimodal issues/PRs about multimodal data processing label Jan 30, 2024
@drcege drcege added this to the Basic Multimodal Support milestone Jan 30, 2024
chenhesen
chenhesen approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@chenhesen chenhesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drcege drcege merged commit 77c7559 into main Jan 30, 2024
5 checks passed
@HYLcool HYLcool deleted the enhance/face_area_filter branch March 7, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenhesen chenhesen chenhesen approved these changes

@HYLcool HYLcool Awaiting requested review from HYLcool

@BeachWang BeachWang Awaiting requested review from BeachWang

@zhijianma zhijianma Awaiting requested review from zhijianma

@yxdyc yxdyc Awaiting requested review from yxdyc

Assignees

@drcege drcege

Labels
dj:multimodal issues/PRs about multimodal data processing dj:op issues/PRs about some specific OPs enhancement New feature or request
Projects
None yet
Milestone
Basic Multimodal Support
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@drcege @chenhesen