add self supervised depth completion. #711
Conversation
There was a problem hiding this comment.
linter test failed, please merge master and refer to https://github.com/modelscope/modelscope/blob/master/docs/source/develop_cn.md#1-%E4%BB%A3%E7%A0%81%E9%A3%8E%E6%A0%BC to format your code
| @@ -0,0 +1,34 @@ | |||
| calib_time: 09-Jan-2012 13:57:47 | |||
There was a problem hiding this comment.
this file should be added to model directory rather than code library, even though this is data releated, which probably on fit for kitti dataset?
| Tasks.self_supervised_depth_completion, module_name=Models.self_supervised_depth_completion) | ||
| class SelfSupervisedDepthCompletion(TorchModel): | ||
| """SelfSupervisedDepthCompletion Class""" | ||
| def __init__(self, model_dir: str, *args, **kwargs): |
There was a problem hiding this comment.
model is expected to be a subclass of TorchModel which should have init func to initiate the network of model, and call function which implements the forward process of the model. it seems this model implementation is more like a trainer
| model_dir = inputs['model_dir'] | ||
| source_dir = inputs['source_dir'] | ||
| self.model.run(model_dir, source_dir) | ||
| return {OutputKeys.OUTPUT: 'Done'} |
There was a problem hiding this comment.
as declared in outputs.py, the output of this pipeline should be an image with a key called 'output_image'
|
|
||
| @PIPELINES.register_module( | ||
| Tasks.self_supervised_depth_completion, module_name=Pipelines.self_supervised_depth_completion) | ||
| class SelfSupervisedDepthCompletionPipeline(Pipeline): |
There was a problem hiding this comment.
please refer to https://github.com/modelscope/modelscope/blob/master/modelscope/pipelines/cv/card_detection_correction_pipeline.py#L36 to add more docstr for pipeline
| "output": { | ||
| "type": "object", | ||
| "properties": { | ||
| "output": { |
There was a problem hiding this comment.
the key str and type should be the same as declared in outputs.py
heyyxd
force-pushed
the
feature/add_self_supervised_depth_completion
branch
from
7730714
to
756a87a
Compare
No description provided.