-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support torchrun_args for dpo cli and support web_ui model deployment #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add examples aigc text_to_image
add diffusers version
fix sdxl sh file
modify inference scripts
support dpo cli and add examples controlnet and dreambooth
fix load adapter layers and some error
fix dreambooth lora sdxl fp16
Modify values of some arguments in sdxl
fix web_ui chatbot
swift/cli/main.py
Outdated
@@ -50,7 +50,7 @@ def cli_main() -> None: | |||
argv = argv[1:] | |||
file_path = importlib.util.find_spec(ROUTE_MAPPING[method_name]).origin | |||
torchrun_args = get_torchrun_args() | |||
if torchrun_args is None or method_name != 'sft': | |||
if torchrun_args is None or method_name != 'sft' or method_name != 'dpo': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
method_name not in (xxx, xxx)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Modify condition judgment for dpo cli
Jintao-Huang
approved these changes
Mar 6, 2024
tastelikefeet
added a commit
to tastelikefeet/swift
that referenced
this pull request
Mar 6, 2024
* commit '8a128f2549d294140c6f5e1400fb8164575fda32': fix transformers==4.33.* (modelscope#498) support torchrun_args for dpo cli and support web_ui model deployment (modelscope#496)
tastelikefeet
added a commit
to tastelikefeet/swift
that referenced
this pull request
Mar 13, 2024
* main: (22 commits) Fix galore linears (modelscope#541) fix checkpoint in model_id_or_path (modelscope#542) Neftune support VL models (modelscope#539) update multi-modal docs (modelscope#538) support deepseek vl (modelscope#536) Support deepseek vl (modelscope#535) Update multi modal docs (modelscope#524) Support GaLore (modelscope#532) fix gradio (modelscope#533) Support cogvlm (modelscope#531) Fix web-ui more-params (modelscope#530) fix hyper parameters (modelscope#529) Support npu (modelscope#528) fix typo Fix test cases (modelscope#526) Support deployment (modelscope#523) update qwen1.5 best practice (modelscope#520) Add transfer README for cources (modelscope#518) revert code Revert "support torchrun_args for dpo cli and support web_ui model deployment (modelscope#496)" ... # Conflicts: # swift/llm/utils/argument.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.support torchrun_args for swift dpo cli
2.support model deployment for swift web_ui