[ScrollableControl] DisplayRectangle should be unscaled values. #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great job solving this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #51
ScrollableControloverridesControl.DisplayRectangleto remove additional space for scrollbars and padding. However by usingClientRectangleit was calculating a scaled size instead of an unscaled size. This meant on a 200% DPI system the total area was 4X the expected size.Because
DisplayRectangleis the size measurement used by the layout system, controls that were docked in this control were sized at 4X. If they themselves wereScrollableControls then they would be 4X also, resulting in 16X, etc.This causes enormous Skia buffers to be allocated, resulting in absurd memory usage on HiDPI machines.
Fix to be an unscaled size.