Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement of a matmul + use of merge #181

Merged
merged 6 commits into from
May 9, 2024
Merged

Conversation

jvdp1
Copy link
Collaborator

@jvdp1 jvdp1 commented May 3, 2024

No description provided.

@jvdp1
Copy link
Collaborator Author

jvdp1 commented May 3, 2024

As discussed, to be tested on different datasets

@milancurcic
Copy link
Member

Some quick and dirty timing timings of examples/dense_mnist. This is on AMD Ryzen 5 5500U (lower end mobile CPU):

GFortran 11

  • fpm profile debug:
    • main: ~35 s
    • jvdp1:optim: ~20s
  • fpm profile release, -fno-frontend-optim:
    • main: ~25 s
    • jvdp1:optim: ~9s
  • fpm profile release:
    • main: ~8 s, does not converge (bad result!)
    • jvdp1:optim: ~6 s, converges (good result!)

ifort classic 2021.10

  • profile release:
    • main: ~8.2 s
    • jvdp1:optim: ~5.3 s

The overall training speed up is very nice, but the best part is that this PR also fixes the erroneous behavior with GFortran in release mode which previously required -fno-frontend-optimize.

@jvdp1 is this PR still a draft or can we mark it as "Ready for review"?

@milancurcic milancurcic added the enhancement New feature or request label May 9, 2024
@jvdp1
Copy link
Collaborator Author

jvdp1 commented May 9, 2024

Thank you @milancurcic for testing the changes. It is actually ready.

@jvdp1 jvdp1 marked this pull request as ready for review May 9, 2024 17:06
@milancurcic
Copy link
Member

Excellent, I'll go ahead and merge it then. Thank you!

@milancurcic milancurcic merged commit 6dfaed0 into modern-fortran:main May 9, 2024
2 checks passed
@jvdp1 jvdp1 deleted the optim branch May 9, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants