gccgo compatibility #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t only works with gcgo and doesn't work with gccgo. Disabling compilation of type_map.go for gccgo.
Codecov Report
@@ Coverage Diff @@
## master #10 +/- ##
=======================================
Coverage 60.58% 60.58%
=======================================
Files 20 20
Lines 751 751
=======================================
Hits 455 455
Misses 280 280
Partials 16 16
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of projects use
reflect2.TypeOf, but they can't be built with gccgo because of the wayreflect2.TypeByNameis implemented. Here's a slight modification to have gccgo skiptype_map.go.Projects that use
reflect2.TypeByNamewill still be unbuildable by gccgo, but all the rest of reflect2 should work.This fixes #6 and #9