Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs/ to .gitignore #50

Closed
rudeboybert opened this issue Jul 13, 2018 · 3 comments
Closed

Add docs/ to .gitignore #50

rudeboybert opened this issue Jul 13, 2018 · 3 comments
Assignees

Comments

@rudeboybert
Copy link
Member

rudeboybert commented Jul 13, 2018

@ismayc Is there any reason to keep docs/ synced on GitHub, since travis-ci renders the book to the gh-pages branch? I feel like we should only sync changes to .Rmd and .yml files and images/data files, otherwise it increases the chances of merge conflicts and makes for harder commit/branch comparisons.

@rudeboybert
Copy link
Member Author

rudeboybert commented Jul 13, 2018

Also perhaps instead have travis-ci copy the contents of the gh-pages rendered book to the master branch docs/ folder in the case there are still floating GitHub pages https://moderndive.github.io/moderndive_book/ links out there?

Updated: nevermind, this will only cause merge conflicts with our local versions of docs/

@ismayc
Copy link
Member

ismayc commented Jul 13, 2018

I like being able to have a backup just in case travis isn’t working. Merge conflicts should be pretty minimal and if they do exist we can just pull down and then recompile. The docs folder doesn’t have to be updated that frequently but can still be useful at times I think.

@rudeboybert
Copy link
Member Author

fine by me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants