BCP20-1235 Add sanitization on setValue for CustomField.php model #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BCP20-1235 Add sanitization on setValue for CustomField.php model
Values provided by merchants in BC admin may have extra chars which may cause the issue(wrong string length)
The example of string
The amazingly small XDv2 amplifiers are huge in audio performance, thanks to our advanced NexD™ switching technologies. These technologies allow XDv2 amplifiers to achieve efficiencies exceeding 80%, meaning far less heat and strain on your vehicle'sThe problem in NexD™ word. Since it hast the extra char it will be count as 2 char and string with length 250 on BC side and will have 251 length on PHP side