Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/119464 rsvp attendee registration position #1013

Merged

Conversation

paulmskim
Copy link
Contributor

@paulmskim paulmskim commented Dec 11, 2018

@paulmskim paulmskim added the code review Status: requires a code review. label Dec 11, 2018
nealfennimore
nealfennimore previously approved these changes Dec 11, 2018
@nealfennimore nealfennimore added merge Status: ready to merge. and removed code review Status: requires a code review. labels Dec 11, 2018
mitogh
mitogh previously approved these changes Dec 11, 2018
@tr1b0t
Copy link
Contributor

tr1b0t commented Dec 20, 2018

Closing this Pull Request because it is pull requested against the wrong branch. The Central ticket is for G19.01, but this was pull requested against release/M19.01.

@tr1b0t tr1b0t closed this Dec 20, 2018
@nealfennimore nealfennimore reopened this Dec 20, 2018
Copy link
Contributor

@sc0ttkclark sc0ttkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog, but looks good

@sc0ttkclark sc0ttkclark added the enhance Code could use some enhancements before merging. label Jan 4, 2019
@paulmskim paulmskim dismissed stale reviews from mitogh and nealfennimore via a95a79b January 4, 2019 17:00
@paulmskim paulmskim removed the enhance Code could use some enhancements before merging. label Jan 4, 2019
@sc0ttkclark sc0ttkclark merged commit 93c304e into release/M19.01 Jan 4, 2019
@sc0ttkclark sc0ttkclark deleted the fix/119464-rsvp-attendee-registration-position branch January 4, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Status: ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants