Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set display price to 0 if blank string #1014

Merged
merged 5 commits into from
Jan 5, 2019

Conversation

paulmskim
Copy link
Contributor

@paulmskim paulmskim commented Dec 11, 2018

For ticket: https://central.tri.be/issues/ 119410

@paulmskim paulmskim added the code review Status: requires a code review. label Dec 11, 2018
mitogh
mitogh previously approved these changes Dec 11, 2018
Copy link
Contributor

@mitogh mitogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing special but up to you if you wanna change it.

@mitogh mitogh added merge Status: ready to merge. and removed code review Status: requires a code review. labels Dec 11, 2018
bordoni
bordoni previously approved these changes Dec 17, 2018
@tr1b0t
Copy link
Contributor

tr1b0t commented Dec 20, 2018

Closing this Pull Request because it is pull requested against the wrong branch. The Central ticket is for G19.01, but this was pull requested against release/M19.01.

@tr1b0t tr1b0t closed this Dec 20, 2018
@nealfennimore nealfennimore reopened this Dec 20, 2018
Copy link
Contributor

@sc0ttkclark sc0ttkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs changelog

@sc0ttkclark sc0ttkclark added the enhance Code could use some enhancements before merging. label Jan 4, 2019
@paulmskim paulmskim dismissed stale reviews from bordoni and mitogh via 1f425ee January 4, 2019 17:01
@paulmskim paulmskim removed the enhance Code could use some enhancements before merging. label Jan 4, 2019
@sc0ttkclark sc0ttkclark merged commit 41a3c8e into release/M19.01 Jan 5, 2019
@sc0ttkclark sc0ttkclark deleted the fix/119410-ticket-block-default-price branch January 5, 2019 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge Status: ready to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants