Promotional updates #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zbtirrell
commented
Mar 17, 2017
zbtirrell
commented
- update readme
- update admin notices
- update description on plugins page
borkweb
reviewed
Mar 17, 2017
image-widget.php
Outdated
| @@ -438,7 +447,7 @@ public function post_upgrade_nag() { | |||
| */ | |||
| public function plugin_row_meta( $meta, $file ) { | |||
| if ( $file == plugin_basename( dirname( __FILE__ ) . '/image-widget.php' ) ) { | |||
| $meta[] = '<span class="tribe-test">' . sprintf( __( 'Check out our other <a href="%s" target="_blank">plugins</a> including our <a href="%s" target="_blank">Events Calendar Pro</a>!', 'image-widget' ), 'https://theeventscalendar.com/products/?source=image-widget&pos=pluginlist', 'https://theeventscalendar.com/product/wordpress-events-calendar-pro/?source=image-widget&pos=pluginlist' ) . '</span>'; | |||
| $meta[] = '<strong>Coming Soon:</strong> <a href="http://m.tri.be/19ma" target="_blank">' . __( 'Image Widget Plus', 'image-widget' ) . '</a>'; | |||
There was a problem hiding this comment.
esc_html__()for Image Widget Plus?- Add
esc_html__()for "Coming Soon"
barryhughes
reviewed
Mar 17, 2017
image-widget.php
Outdated
| <div class="update-nag"> | ||
| <?php esc_html_e( 'Thanks for using the Image Widget by Modern Tribe! If you like these features, you\'ll love what we\'re working on next.', 'image-widget' );?> | ||
| <br> | ||
| <?php echo sprintf( |
There was a problem hiding this comment.
Not essential, but printf() is a little more concise then echo sprintf()
barryhughes
reviewed
Mar 17, 2017
image-widget.php
Outdated
| esc_html__( 'Check out the new %1$sImage Widget Plus%2$s!', 'image-widget' ), | ||
| '<a href="http://m.tri.be/19mb" target="_blank">', | ||
| '</a>' | ||
| );?> |
barryhughes
reviewed
Mar 17, 2017
readme.txt
Outdated
| [Check us out on GitHub](https://github.com/moderntribe/image-widget) in case you want to add some pull requests or a fork! | ||
| = Pull Requests & Translations = | ||
|
|
||
| to add your pull requests, translations, or a fork. Translations can also be submitted in [our forum here on WordPress.org](https://wordpress.org/support/plugin/image-widget/). |
There was a problem hiding this comment.
Start this sentence with a capital letter?
There was a problem hiding this comment.
Also, seems a little weird (to me) to have "Translations can also be submitted..." here and below the "Check us out on GitHub" link -- the second link seems preferable to me as it goes straight to the translations project.
|
this is ready for review again |
borkweb
approved these changes
Mar 20, 2017
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.