Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/TEC-3635 - Make default limit by number of events instead of by date range #3339

Closed
wants to merge 10 commits into from
Closed

Fix/TEC-3635 - Make default limit by number of events instead of by date range #3339

wants to merge 10 commits into from

Conversation

codingmusician
Copy link
Contributor

JIRA Ticket: TEC-3635

  • Having the default import limit setting be by number instead of date range is a better UX for our customers

@codingmusician codingmusician self-assigned this Nov 12, 2020
tr1b0t
tr1b0t reviewed Nov 12, 2020
View reviewed changes
Copy link
Contributor

@tr1b0t tr1b0t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ 1 warning(s)

@mitogh mitogh changed the base branch from master to release/B20.11 November 12, 2020 20:56
mitogh
mitogh reviewed Nov 12, 2020
View reviewed changes
Copy link
Contributor

@mitogh mitogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good make sure the bot comments are addressed as well with the git conflicts.

@mitogh mitogh added the enhance Status: Code could use some enhancements before merging. label Nov 12, 2020
tr1b0t
tr1b0t reviewed Nov 12, 2020
View reviewed changes
Copy link
Contributor

@tr1b0t tr1b0t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ 1 warning(s)

src/admin-views/aggregator/settings.php Outdated Show resolved Hide resolved
mitogh
mitogh previously approved these changes Nov 12, 2020
View reviewed changes
@codingmusician codingmusician removed the request for review from tr1b0t November 13, 2020 12:44
@codingmusician codingmusician added this to the Release 20.11 milestone Nov 13, 2020
@mitogh
Copy link
Contributor

mitogh commented Nov 16, 2020

Can you make sure the additional changes from this PR are intentional ?

Thanks @codingmusician

@codingmusician codingmusician deleted the fix/TEC-3635 branch November 16, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tr1b0t tr1b0t tr1b0t left review comments

@mitogh mitogh Awaiting requested review from mitogh

Assignees

@codingmusician codingmusician

Labels
enhance Status: Code could use some enhancements before merging.
Projects
None yet
Milestone
Release 20.11
Development

Successfully merging this pull request may close these issues.
4 participants
@codingmusician @mitogh @tr1b0t @bordoni