Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Drastically simplifies regions #1400

Merged
merged 4 commits into from
May 19, 2023
Merged

Conversation

kamronbatman
Copy link
Contributor

@kamronbatman kamronbatman commented Apr 30, 2023

Summary

  • Gets rid of the Dtos
  • Simplifies the json serializer registration
  • Adds a custom RegionByName JsonConverter that can look up other regions that have already been registered.

BREAKING CHANGE

  1. Child regions must appear after their parents in the JSON file
  2. In the regions json file, "Parent" can no longer be just a string. It must be an object that includes the map.
    • "Parent": { "Name": "Britain", "Map": "Felucca" }

@kamronbatman kamronbatman merged commit 0a9bfb0 into main May 19, 2023
@kamronbatman kamronbatman deleted the kbatman/simplify_regions branch May 19, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant