Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up: Null/Deleted checks, eable LINQ, default arguments, default constructors, various misc broken stuff. #18

Merged
merged 55 commits into from Mar 11, 2019
Merged

Clean up: Null/Deleted checks, eable LINQ, default arguments, default constructors, various misc broken stuff. #18

merged 55 commits into from Mar 11, 2019

Conversation

kamronbatman
Copy link
Contributor

@kamronbatman kamronbatman commented Mar 4, 2019 •
edited

  • Fixes default values in constructors
  • BREAKING CHANGE: Fixes food constructor argument order.
  • Fixes GetFightModeRanking
  • Update eables to use LINQ where it makes sense
  • Removes backwards compatible single-threaded socket code for .NET Framework < 4.0
  • Integrates NEWPARENT (IEntity instead of object) and removes the option for backwards compatibility
  • BREAKING CHANGE: Fixes spell constructor argument order.

@kamronbatman kamronbatman mentioned this pull request Mar 4, 2019
Closed
22 tasks
@kamronbatman
Updates more default value constructors
d1c102f
@kamronbatman
Merge branch 'develop' of github.com:kamronbatman/ModernUO into clean…
b307f62 
…up/null_checks_1
@kamronbatman
Merges with develop. Updates more constructors and fixes a few minor …
5cb23fc 
…bugs from the old RunUO days.
@kamronbatman
Updates more constructors. Fixes food with its backwards arguments.
42841bc
@kamronbatman
Fixes default value constructors for ML items.
844bb0f
@kamronbatman
More null check cleanup
7b0b932
@kamronbatman
Collapses more null-delete checks.
260de25
@kamronbatman
Removes redundant casts
2a25e7b
@kamronbatman
Adds some missing null checks and collapses more null-delete checks.
e8cac33
@kamronbatman
Collapses more null-delete checks.
7400ee4
@kamronbatman
Fixes bugs with null-delete checks. Lots of old school copy-pasta for…
c88792e 
… sure.
@kamronbatman
Merge branch 'develop' of github.com:kamronbatman/ModernUO into clean…
24d5f96 
…up/null_checks_1
@kamronbatman
Changes editor config to 2 spaces to be consistent with rest of forma…
94637b0 
…t. Fixes more null-delete and bad if statements.
@kamronbatman
Attempt to remove the massive diff.
cf4c7ec
@kamronbatman
Fixes linefeed in editorconfig.
bb1c0d9
@kamronbatman
Fixes spelling in editorconfig. Fixes more null-deleted checks.
99afc80
@kamronbatman
Collapses more null-delete checks.
b85b1e9
@kamronbatman
Last of the null-delete checks.
cb915e9
@kamronbatman
Removes overloads for default value methods.
f563794
@kamronbatman
Reverts base talisman and removes default arguments.
e7d19ac
@kamronbatman
More code formatting and null check cleanup
178533b
@kamronbatman
Removes default value arguments and fixes more null checks.
55793e2
@kamronbatman kamronbatman marked this pull request as ready for review March 6, 2019 23:33
@kamronbatman kamronbatman changed the title Cleans up some more null checks. Clean up: Null/Deleted checks, eable LINQ, default arguments, default constructors, various misc broken stuff. Mar 6, 2019
@kamronbatman
Removes Drawing dependency on core.
1ffc47e
@kamronbatman
Merge branch 'develop' into cleanup/null_checks_1
7317894
@kamronbatman
Various cleanup.
09aa3c5
@kamronbatman
Various cleanup
908d693
@kamronbatman
Cleanup for FastMovement. Fixes UTF-BE16 and BOM on project files.
edf2c77
@kamronbatman
More null check cleanups.
442f377
@kamronbatman
Removed the old socket code.
88418ce
@kamronbatman
Fixes a few minor bugs.
4023207
@kamronbatman
More null check cleanups.
648f8fa
@kamronbatman
Fixes default values for gump buttons.
4f5209b
@kamronbatman
Sets spell item scroll argument as null for default.
9cf06ba
@kamronbatman
Fixes spell argument arrangement
20949c3
@kamronbatman
Adding more default values for gumps.
c13da90
@kamronbatman
More cleanup.
a8b36d3
@kamronbatman
Collapses more null checks. Fixes a few bugs with regions.
0054f83
@kamronbatman
Collapses more checks and moves icomparables to generics.
77c0454
@kamronbatman
Misc cleanup and removing dangling commas
5e49e64
@kamronbatman
More misc cleanup
8cba618
@kamronbatman
Removes variable that is not needed.
7083de9
@kamronbatman kamronbatman merged commit 513e54f into develop Mar 11, 2019
@kamronbatman kamronbatman deleted the cleanup/null_checks_1 branch March 11, 2019 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kamronbatman