fix: Fixes dupe property copying. Adds IgnoreDupe #1811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kamronbatman
commented
May 31, 2024
Comment on lines
-542
to
-548
| book.Content = _content; | ||
| book.SpellCount = _spellCount; | ||
| book.Slayer = _slayer; | ||
| book.Slayer2 = _slayer2; | ||
| book.Quality = _quality; | ||
| book.EngravedText = _engravedText; | ||
| book.Crafter = _crafter; |
There was a problem hiding this comment.
Removed primitives that were copied afterwards that didn't need to be.
kamronbatman
force-pushed
the
kbatman/fix_dupe
branch
from
45e24e0
to
46dfc08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
[IgnoreDupe]and[SerializedIgnoreDupe]Item.Dupe()command and encapsulatesCopyPropertiesandOnAfterDuped. This is also overridable.Bug Fixes
Note
Developer Note
Customizing how duping an item works now requires two steps:
[IgnoreDupe]or[SerializedIgnoreDupe]to the property/fieldOnAfterDupedoverrideWhen do you need to do this?
When the property being copied is not a primitive, and you need to manually deep-clone the contents of the property such as with Lists, Dictionaries, or sub classes.