New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fixes double calls with Target cancel and spell sequences #1840

Merged

kamronbatman merged 5 commits into main from kbatman/remove_double_sequences

Jun 17, 2024

Contributor

kamronbatman commented Jun 17, 2024 •

edited

Loading

Summary

Cleans up target cancellation being called incorrectly.
An invalid target type (which should never happen), now calls OnTargetUntargetable instead of OnTargetCanceled
Removes double calls to FinishSequence in Spells.

kamronbatman added 5 commits

June 17, 2024 14:46


          fix: Fixes double calls with Target cancel and spell sequences

fde9cae


          Cleans up recall spells

d4f40e5


          Removes invalid type cancel

639faeb


          Use consistent arguments

58ac29f


          Cleans up scissor targeting

7d097f5

kamronbatman merged commit b8ad5c6 into main

11 of 12 checks passed

kamronbatman deleted the kbatman/remove_double_sequences branch

June 17, 2024 22:19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment