Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Optimizes strings / .NET 5 compatibility changes #354

Merged
merged 21 commits into from
Dec 21, 2020
Merged

fix(core): Optimizes strings / .NET 5 compatibility changes #354

merged 21 commits into from
Dec 21, 2020

Conversation

kamronbatman
Copy link
Contributor

@kamronbatman kamronbatman commented Dec 19, 2020 •
edited
Loading

  • Removes some string allocations (e.g. split)
  • Optimizes some collections
  • Converts insensitive to extension methods of built-ins.
  • Adds ordinal (case sensitive) string helpers
  • Fixes conditionals for in-game commands so they use Ordinal comparisons.
  • Replaces ToLower.Contains with InsensitiveContains
  • Adds ValueStringBuilder
  • Implements ValueStringBuilder in a few places where it makes sense
  • Removes the redundant Wrap function and replaces it with an optimized version
  • Fixes list conversions in Utility

Closes #351

@kamronbatman kamronbatman changed the title Removes some string memory allocations fix(core): Optimizes strings / .NET 5 compatibility changes Dec 20, 2020
@kamronbatman kamronbatman merged commit 77ce2e1 into master Dec 21, 2020
@kamronbatman kamronbatman deleted the kbatman/remove_allocations branch December 21, 2020 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update string split to use Tokenize instead
1 participant
@kamronbatman