New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update string comparisons #50

Closed

1 task

kamronbatman opened this issue Sep 8, 2019 · 3 comments

Labels

Contributor

kamronbatman commented Sep 8, 2019

Update string comparison (EndsWith etc) with Span handling.

kamronbatman added the enhancement label

Contributor

3HMonkey commented Jan 6, 2020 •

edited

Loading

BTW, here is s short summary about this: https://www.stevejgordon.co.uk/an-introduction-to-optimising-code-using-span-t
Also seems like MemoryExtensions could be used (
MemoryExtensions.EndsWith(line, ")", StringComparison.Ordinal)
)
https://docs.microsoft.com/en-us/dotnet/api/system.memoryextensions.endswith?view=netcore-3.1

Contributor Author

kamronbatman commented Jan 14, 2020

I recommend making a StringUtils class in the core.

Contributor Author

kamronbatman commented Dec 16, 2020

This is related to #351

kamronbatman closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment