fix(test-runner-puppeteer): add createBrowserContext

modernweb-dev · Dec 25, 2023 · 22797cd · 22797cd
1 parent 245123e
commit 22797cd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/heavy-items-trade.md b/.changeset/heavy-items-trade.md
@@ -0,0 +1,5 @@
+---
+'@web/test-runner-puppeteer': patch
+---
+
+Fixes `createBrowserContext` which previously had no effect and was never called.
diff --git a/packages/test-runner-puppeteer/src/puppeteerLauncher.ts b/packages/test-runner-puppeteer/src/puppeteerLauncher.ts
@@ -1,23 +1,26 @@
 import * as puppeteer from 'puppeteer';
 import * as puppeteerCore from 'puppeteer-core';
-import { Browser, Page, PuppeteerNodeLaunchOptions } from 'puppeteer-core';
+import { Browser, BrowserContext, Page, PuppeteerNodeLaunchOptions } from 'puppeteer-core';
 import { BrowserLauncher, TestRunnerCoreConfig } from '@web/test-runner-core';
 import { chromeLauncher } from '@web/test-runner-chrome';
 
 export interface PuppeteerLauncherConfig {
   launchOptions?: PuppeteerNodeLaunchOptions;
+  createBrowserContext?: (args: { config: TestRunnerCoreConfig; browser: Browser }) => BrowserContext | Promise<BrowserContext>;
   createPage?: (args: { config: TestRunnerCoreConfig; browser: Browser }) => Promise<Page>;
   concurrency?: number;
 }
 
 export function puppeteerLauncher({
   launchOptions,
+  createBrowserContext,
   createPage,
   concurrency,
 }: PuppeteerLauncherConfig = {}): BrowserLauncher {
   return chromeLauncher({
     launchOptions,
     puppeteer: (puppeteer as any).default as typeof puppeteerCore,
+    createBrowserContext,
     createPage,
     concurrency,
   });