Skip to content

Commit

Permalink
test: add test for null character and esbuild
Browse files Browse the repository at this point in the history
  • Loading branch information
edoardocavazza committed Apr 20, 2021
1 parent dd4d9cc commit a971dbe
Show file tree
Hide file tree
Showing 2 changed files with 39 additions and 0 deletions.
1 change: 1 addition & 0 deletions packages/dev-server-esbuild/package.json
Expand Up @@ -58,6 +58,7 @@
},
"devDependencies": {
"@types/ua-parser-js": "^0.7.35",
"@web/dev-server-rollup": "^0.3.3",
"lit-element": "^2.4.0",
"node-fetch": "3.0.0-beta.9",
"preact": "^10.5.9"
Expand Down
38 changes: 38 additions & 0 deletions packages/dev-server-esbuild/test/ts.test.ts
Expand Up @@ -3,6 +3,8 @@ import { expect } from 'chai';
import fetch from 'node-fetch';
import { createTestServer } from '@web/dev-server-core/test-helpers';
import { expectIncludes, expectNotIncludes } from '@web/dev-server-core/test-helpers';
import { Plugin as RollupPlugin } from 'rollup';
import { fromRollup } from '@web/dev-server-rollup';

import { esbuildPlugin } from '../src/index';

Expand Down Expand Up @@ -205,4 +207,40 @@ class Bar {
server.stop();
}
});

it('imports with a null byte are rewritten to a special URL', async () => {
const plugin: RollupPlugin = {
name: 'my-plugin',
load(id) {
if (id === path.join(__dirname, 'app.js')) {
return 'import "\0foo.js";';
}
},
resolveId(id) {
if (id === '\0foo.js') {
return id;
}
},
};
const { server, host } = await createTestServer({
rootDir: __dirname,
plugins: [
fromRollup(() => plugin)(),
esbuildPlugin({
js: true,
}),
],
});

try {
const response = await fetch(`${host}/app.js`);
const text = await response.text();
expectIncludes(
text,
'import "/__web-dev-server__/rollup/foo.js?web-dev-server-rollup-null-byte=%00foo.js"',
);
} finally {
server.stop();
}
});
});

0 comments on commit a971dbe

Please sign in to comment.