Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add storybook builder tests #2485

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Conversation

bashmish
Copy link
Member

@bashmish bashmish commented Oct 17, 2023

What I did

  1. added automated tests for the storybook builder, most importantly the static build which catches a lot of stuff, and a few GUI smoke tests to check that different things render, both in runtime and in the static build

@changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2023

⚠️ No Changeset found

Latest commit: 728e81f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@bashmish bashmish marked this pull request as draft October 17, 2023 16:22
@bashmish bashmish force-pushed the feat/test-storybook-builder branch 6 times, most recently from d7b930a to db6398d Compare March 3, 2024 11:13
@bashmish bashmish force-pushed the feat/test-storybook-builder branch 4 times, most recently from 17fcdfb to 47cd660 Compare March 11, 2024 17:22
@bashmish bashmish force-pushed the feat/test-storybook-builder branch 2 times, most recently from c426522 to 8cc26e8 Compare March 17, 2024 19:31
@bashmish bashmish closed this Mar 17, 2024
@bashmish bashmish force-pushed the feat/test-storybook-builder branch from fd45ac4 to 0b8390f Compare March 17, 2024 22:50
@bashmish bashmish reopened this Mar 17, 2024
@bashmish bashmish marked this pull request as ready for review March 17, 2024 22:51
@bashmish bashmish force-pushed the feat/test-storybook-builder branch 2 times, most recently from 263adfb to 7a1ed07 Compare March 17, 2024 23:51
@bashmish bashmish force-pushed the feat/test-storybook-builder branch from 7a1ed07 to 6cf1e79 Compare March 18, 2024 00:19
@bashmish bashmish changed the title WIP Storybook Builder Tests test: add storybook builder tests Mar 18, 2024
@bashmish bashmish force-pushed the feat/test-storybook-builder branch from 6cf1e79 to 5f67eb7 Compare March 18, 2024 00:21
@bashmish bashmish force-pushed the feat/test-storybook-builder branch from 5f67eb7 to 728e81f Compare March 18, 2024 00:32
@bashmish bashmish merged commit 2f04ee7 into master Mar 18, 2024
6 of 7 checks passed
@bashmish bashmish deleted the feat/test-storybook-builder branch March 18, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant