Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add option to modify chokidar watchOptions with @web/dev-server #2614

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

Matsuuu
Copy link
Contributor

@Matsuuu Matsuuu commented Jan 20, 2024

What I did

  1. Added option to provide chokidar Watchoptions to the web dev server watcher. This is due to numerous errors with especially windows environments not being able to utilize the dev server due to watch/file update errors.

Examples of said error happening

With this, we are able to provide a non-changed environment for all users, but provide extra configurability to the file watchers ( and therefore to caching, watchers, etc.) through the chokidarOptions tag.


Is there any other parts of the codebase this should touch? I'm not too familiar with changesets etc so please advice

Copy link

changeset-bot bot commented Jan 20, 2024

⚠️ No Changeset found

Latest commit: fa46b6c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Matsuuu
Copy link
Contributor Author

Matsuuu commented Jan 20, 2024

Requesting a review of this from at least @thepassle as we discussed this

@thepassle thepassle merged commit 46233e0 into modernweb-dev:master Jan 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants