Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev-server-core): fix readonly error serialization #2731

Merged
merged 1 commit into from
May 12, 2024

Conversation

lucaelin
Copy link
Contributor

Fixes #2728

What I did

  1. Add integration test for error reporting with readonly / frozen objects
  2. Create a structuredClone of messages when running stringification with (mutating) circurlar reference removal

Copy link

changeset-bot bot commented May 12, 2024

🦋 Changeset detected

Latest commit: 4a4b699

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/dev-server-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thepassle thepassle merged commit feb0c72 into modernweb-dev:master May 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@web/test-runner] Tests do not finish when asserting frozen objects
2 participants