Rails 4 2 #38
Rails 4 2 #38
Conversation
| @@ -126,6 +126,7 @@ | |||
| When /^I change the slug to "([^"]*)"/ do |path| | |||
| fill_in 'Slug', :with => path | |||
| click_button 'Update Page' | |||
| page.should_not have_content('Update Page') | |||
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
@jejacks0n if you have a few I wanted to just run a couple things by you regarding mercury and teaspoon.
Thanks! |
|
there should be 64 passing JS specs, for reference. |
| expect(page).to have_css('meta[name="keywords"]') | ||
| expect(page).to have_css('meta[content="some_keyword, someother_keyword"]') | ||
| expect(page).to have_css('meta[name="description"]') | ||
| expect(page).to have_css('meta[content="This is a description of the page"]') |
* update to new spec and mock API for rspec
|
@gvarela also like your opinion on the |
|
|
||
| it 'removes trailing slashes' do | ||
| expect(request).to receive(:params).and_return(path: '//path/').at_least(:once) | ||
| expect(Cmsimple::Path.from_request(request).destination.uri).to eq('/some-other-path') |
|
This looks good. Yeah you never check in a Gemfile.lock for a gem. Only for an application. |
| @@ -26,7 +26,7 @@ def update_content | |||
| end | |||
|
|
|||
| def editor | |||
| render :nothing => true, :layout => 'editor' | |||
| render :text => '', :layout => 'editor' | |||
There was a problem hiding this comment.
Use the new Ruby 1.9 hash syntax.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
|
@gvarela could I get your eyes on these last couple commits, it seems like in rails 4.2 |
|
@jejacks0n we're on 0.9.1 for teaspoon. |
|
@jedschneider cool. Can you just call |
updating gem to support Rails 4.2 and modern versions of development libraries like Cucumber and RSpec