Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 141 - Assembly definitions Unity 2019.3.0 - Closes 141 #142

Merged
merged 4 commits into from
May 24, 2020
Merged

Fix 141 - Assembly definitions Unity 2019.3.0 - Closes 141 #142

merged 4 commits into from
May 24, 2020

Conversation

Mathijs-Bakker
Copy link
Collaborator

Thank you for sending a pull request! Please make sure you read the contribution guidelines

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • No compiler errors

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Issue Number

#141

Issue Number: N/A

Create or search an issue here: Extenject/Issues

What is the current behavior?

  • Compiler throws errors for the assembly definitions of the Zenject Test Suite (optional extras)

What is the new behavior?

  • Tests run without any issue.

Does this introduce a breaking change?

  • Yes
  • No

Other information

On which Unity version has this been tested?

  • 2020.4 LTS
  • 2020.3
  • 2020.2
  • 2020.1
  • 2019.4 LTS
  • 2019.3
  • 2019.2
  • 2019.1
  • 2018.4 LTS

Scripting backend:

  • Mono
  • IL2CPP

Note: Every pull request is tested on the Continuous Integration (CI) system to confirm that it works in Unity.

Ideally, the pull request will pass ("be green"). This means that all tests pass and there are no errors. However, it is not uncommon for the CI infrastructure itself to fail on specific platforms or for so-called "flaky" tests to fail ("be red"). Each CI failure must be manually inspected to determine the cause.

CI starts automatically when you open a pull request, but only Releasers/Collaborators can restart a CI run. If you believe CI is giving a false negative, ask a Releaser to restart the tests.

@Mathijs-Bakker Mathijs-Bakker merged commit c2e3350 into modesttree:master May 24, 2020
@Mathijs-Bakker Mathijs-Bakker linked an issue May 24, 2020 that may be closed by this pull request
@Mathijs-Bakker Mathijs-Bakker deleted the fix-141-AssemblyDefinitionsUnity2019_3_0 branch May 24, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI workflow, Zenject test suite fail
1 participant