fix(shapely): handle deprecation warnings from shapely 1.8 #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwtoews
force-pushed
the
shapely-deprecations
branch
from
1b08ee8
to
f9287cd
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1069 +/- ##
==============================================
+ Coverage 16.390% 71.381% +54.990%
==============================================
Files 225 225
Lines 50699 51911 +1212
==============================================
+ Hits 8310 37055 +28745
+ Misses 42389 14856 -27533
|
|
@jlarsen-usgs or @dbrakenhoff let me know if you see any issues with the PR. I will merge the PR unless I hear otherwise from you by Monday. |
|
I just reran the autotests. @jlarsen-usgs and @dbrakenhoff every thing seems fine but let me know if you see anything that concerns you guys and we need to revert the changes. @mwtoews thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shapely 1.8 is in the pre-release stage, and has several deprecation warning messages. Some of these are in preparation for shapely 2.0, which has some breaking changes.
This PR aims to fix the ones that are revealed from the autotest suite. The context manager
ignore_shapely_warnings_for_object_arrayis used to silence false-positive warnings when assigning shapely geometries to object arrays. It shouldn't be used for other legitimate deprecation warnings.