Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug(flopy_io): limit fixed point format string to fixed column widths #1172

Merged
merged 1 commit into from Aug 6, 2021

Conversation

jdhughes-usgs
Copy link
Contributor

flopy_io.write_fixed_var could write a fixed point string (f) that
exceeded the specified fixed column width. Added test to revert to
general format (g) with precision equal to column width - 6 to preserve
as much precision as possible. This value allows for a string with a
sign (+/-) and +/-e307. Added test for issue 1164 to t015_test.py
autotest.

Closes #1164

flopy_io.write_fixed_var could write a fixed point string (f) that
exceeded the specified fixed column width. Added test to revert to
general format (g) with precision equal to column width - 6 to preserve
as much precision as possible. This value allows for a string with a
sign (+/-) and +/-e307. Added test for issue 1164 to t015_test.py
autotest.

Closes modflowpy#1164
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #1172 (9ed4ece) into develop (64094ae) will increase coverage by 0.694%.
The diff coverage is 100.000%.

❗ Current head 9ed4ece differs from pull request most recent head 5090e4d. Consider uploading reports for the commit 5090e4d to get more accurate results

@@              Coverage Diff              @@
##           develop     #1172       +/-   ##
=============================================
+ Coverage   72.298%   72.992%   +0.694%     
=============================================
  Files          229       225        -4     
  Lines        52773     52001      -772     
=============================================
- Hits         38154     37957      -197     
+ Misses       14619     14044      -575     
Impacted Files Coverage Δ
flopy/utils/flopy_io.py 77.732% <100.000%> (+0.273%) ⬆️
flopy/mt3d/mtsft.py 6.569% <0.000%> (-72.263%) ⬇️
flopy/utils/formattedfile.py 89.032% <0.000%> (-2.581%) ⬇️
flopy/utils/mfreadnam.py 75.912% <0.000%> (-1.460%) ⬇️
flopy/modflow/mflmt.py 91.578% <0.000%> (-1.053%) ⬇️
flopy/mf6/utils/testutils.py
flopy/mt3d/mtcts.py
flopy/mf6/utils/reference.py
flopy/utils/voronoi.py
flopy/utils/mflistfile.py 68.680% <0.000%> (+0.223%) ⬆️
... and 1 more

@jdhughes-usgs jdhughes-usgs merged commit 5098c56 into modflowpy:develop Aug 6, 2021
@jdhughes-usgs jdhughes-usgs deleted the issue-1164 branch August 6, 2021 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

STR input files built with flopy
1 participant