fix(csvfile): default csvfile to retain all characters in column names #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
langevin-usgs
commented
Oct 14, 2022
langevin-usgs
commented
- The CsvFile load routine used default np.genfromtxt arguments, including those that would remove spaces, dashes, parentheses and others. This caused problems if these characters were used in obs names, for example. This PR changes default behavior so that these characters are not removed.
* The CsvFile load routine used default np.genfromtxt arguments, including those that would remove spaces, dashes, parentheses and others. This caused problems if these characters were used in obs names, for example. This PR changes default behavior so that these characters are not removed.
Codecov Report
@@ Coverage Diff @@
## develop #1587 +/- ##
==========================================
+ Coverage 30.0% 72.6% +42.6%
==========================================
Files 251 251
Lines 52947 54419 +1472
==========================================
+ Hits 15886 39553 +23667
+ Misses 37061 14866 -22195
|
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
modflowpy#1587) * The CsvFile load routine used default np.genfromtxt arguments, including those that would remove spaces, dashes, parentheses and others. This caused problems if these characters were used in obs names, for example. This PR changes default behavior so that these characters are not removed.
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
modflowpy#1587) * The CsvFile load routine used default np.genfromtxt arguments, including those that would remove spaces, dashes, parentheses and others. This caused problems if these characters were used in obs names, for example. This PR changes default behavior so that these characters are not removed.
wpbonelli
pushed a commit
that referenced
this pull request
Dec 14, 2022
#1587) * The CsvFile load routine used default np.genfromtxt arguments, including those that would remove spaces, dashes, parentheses and others. This caused problems if these characters were used in obs names, for example. This PR changes default behavior so that these characters are not removed.
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
modflowpy#1587) * The CsvFile load routine used default np.genfromtxt arguments, including those that would remove spaces, dashes, parentheses and others. This caused problems if these characters were used in obs names, for example. This PR changes default behavior so that these characters are not removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.